Skip to content

Simplify summary output #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2021
Merged

Simplify summary output #208

merged 1 commit into from
Jul 20, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jul 19, 2021

This less verbose approach to the project and projects linting summary output provides the same amount of information in
a more approachable format.

Before:

Linting library in E:\SomeLibrary
Rule LP017 result: fail
ERROR: Library name Servo is in use by a library in the Library Manager index. Each library must have a unique name value. If your library is already in the index, use the "--library-manager update" flag.
Rule LD002 result: fail
WARNING: No license file found. See: https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/licensing-a-repository#detecting-a-license

Finished linting project. Results:
Warning count: 1
Error count: 1
Rules passed: false

-------------------

Linting sketch in E:\SomeLibrary\examples\Knob

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Finished linting projects. Results:
Warning count: 1
Error count: 1
Rules passed: false

After:

Linting library in E:\SomeLibrary
Rule LP017 result: fail
ERROR: Library name Servo is in use by a library in the Library Manager index. Each library must have a unique name value. If your library is already in the index, use the "--library-manager update" flag.
Rule LD002 result: fail
WARNING: No license file found. See: https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/licensing-a-repository#detecting-a-license

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in E:\SomeLibrary\examples\Knob

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

@per1234
Simplify summary output
6b719bc 
This less verbose approach to the project and projects linting summary output provides the same amount of information in
a more approachable format.
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 19, 2021
@per1234 per1234 requested review from silvanocerza and umbynos July 19, 2021 18:45
@codecov-commenter
Copy link

Codecov Report

Merging #208 (6b719bc) into main (dccb221) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   87.90%   87.93%   +0.02%     
==========================================
  Files          43       43              
  Lines        4150     4160      +10     
==========================================
+ Hits         3648     3658      +10     
  Misses        391      391              
  Partials      111      111
Flag Coverage Δ
unit 87.93% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/result/result.go 89.43% <100.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dccb221...6b719bc. Read the comment docs.

@per1234 per1234 merged commit 24d0055 into arduino:main Jul 20, 2021
@per1234 per1234 deleted the simplify-summary-output branch July 20, 2021 07:57
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@umbynos umbynos Awaiting requested review from umbynos

1 more reviewer

@silvanocerza silvanocerza silvanocerza approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@per1234 per1234

Labels

topic: code Related to content of the project itself type: enhancement Proposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@per1234 @codecov-commenter @silvanocerza